minor static analyzer fixes

This commit is contained in:
bol-van
2026-06-06 10:09:35 +03:00
parent 42a9b8e330
commit 1a1fc38c8e
2 changed files with 2 additions and 5 deletions
+1 -1
View File
@@ -587,7 +587,7 @@ static uint8_t tvb_get_varint(const uint8_t *tvb, uint64_t *value)
return 8; return 8;
} }
// impossible case // impossible case
if (*value) *value = 0; if (value) *value = 0;
return 0; return 0;
} }
static uint8_t tvb_get_size(uint8_t tvb) static uint8_t tvb_get_size(uint8_t tvb)
+1 -4
View File
@@ -835,8 +835,6 @@ static bool handle_unsent(tproxy_conn_t *conn)
static bool proxy_mode_connect_remote(tproxy_conn_t *conn, struct tailhead *conn_list) static bool proxy_mode_connect_remote(tproxy_conn_t *conn, struct tailhead *conn_list)
{ {
int remote_fd;
if (params.debug>=1) if (params.debug>=1)
{ {
char ip_port[48]; char ip_port[48];
@@ -850,9 +848,8 @@ static bool proxy_mode_connect_remote(tproxy_conn_t *conn, struct tailhead *conn
return false; return false;
} }
if (!(conn->partner = new_conn(remote_fd, true))) if (!(conn->partner = new_conn(0, true)))
{ {
close(remote_fd);
DLOG_ERR("socks out-of-memory (1)\n"); DLOG_ERR("socks out-of-memory (1)\n");
socks_send_rep(conn->socks_ver, conn->fd, S5_REP_GENERAL_FAILURE); socks_send_rep(conn->socks_ver, conn->fd, S5_REP_GENERAL_FAILURE);
return false; return false;