From 0085eeba6e1c1bc9a1885582fbe2b1c9711bdde8 Mon Sep 17 00:00:00 2001
From: Bartosz-Do <xbartoszdobija@gmail.com>
Date: Sat, 8 Aug 2026 17:35:17 +0200
Subject: [PATCH] Fix all `pnpm type-check` warnings and restore lost `Props`
 typing (#2805)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: codecalm <1282324+codecalm@users.noreply.github.com>
---
 docs/layouts/DocsLayout.astro                     |  2 +-
 shared/components/cards/Card.astro                |  2 +-
 shared/components/layout/HeaderActionsPrint.astro |  2 +-
 shared/components/marketing/hero/Side.astro       |  2 +-
 shared/layouts/BaseLayout.astro                   |  1 -
 shared/ui/AdvancedTable.astro                     |  2 --
 shared/ui/Card.astro                              | 10 +++++++---
 shared/ui/CardHeader.astro                        | 10 +++++++---
 shared/ui/CardSubtitle.astro                      | 10 +++++++---
 shared/ui/CardTitle.astro                         | 10 +++++++---
 shared/ui/FormHint.astro                          | 10 +++++++---
 shared/ui/ListGroup.astro                         | 10 +++++++---
 shared/ui/ListGroupItem.astro                     | 10 +++++++---
 shared/ui/Subheader.astro                         | 10 +++++++---
 14 files changed, 60 insertions(+), 31 deletions(-)

diff --git a/docs/layouts/DocsLayout.astro b/docs/layouts/DocsLayout.astro
index 454085e04..870de5eec 100644
--- a/docs/layouts/DocsLayout.astro
+++ b/docs/layouts/DocsLayout.astro
@@ -307,7 +307,7 @@ const docsLinks = docs.links as DocsLink[];
 
 				elements.forEach(function (element) {
 					const clipboard = new ClipboardJS(element, {
-						text: function (trigger) {
+						text: function () {
 							return element.getAttribute('data-clipboard-text');
 						}
 					});
diff --git a/shared/components/cards/Card.astro b/shared/components/cards/Card.astro
index 6f504bcc3..1b7648e71 100644
--- a/shared/components/cards/Card.astro
+++ b/shared/components/cards/Card.astro
@@ -31,7 +31,7 @@ interface Props {
 	footer?: boolean;
 	footerButton?: boolean;
 	footerButtons?: boolean;
-	/** a ">" prefix pushes the element (and every following one) to the right — `right` is never reset */
+	/** a right-angle-bracket prefix pushes the element (and every following one) to the right — `right` is never reset */
 	footerElements?: string[];
 	progress?: boolean;
 }
diff --git a/shared/components/layout/HeaderActionsPrint.astro b/shared/components/layout/HeaderActionsPrint.astro
index 154d14d93..178eed0e9 100644
--- a/shared/components/layout/HeaderActionsPrint.astro
+++ b/shared/components/layout/HeaderActionsPrint.astro
@@ -3,7 +3,7 @@ import Icon from '@ui/Icon.astro'
 ---
 
 <!-- BEGIN HEADER ACTIONS -->
-<button type="button" class="btn btn-primary" onclick="javascript:window.print();">
+<button type="button" class="btn btn-primary" onclick="window.print()">
   <Icon name="printer" /> Print Invoice
 </button>
 <!-- END HEADER ACTIONS -->
diff --git a/shared/components/marketing/hero/Side.astro b/shared/components/marketing/hero/Side.astro
index ca6f09a18..eefe0e828 100644
--- a/shared/components/marketing/hero/Side.astro
+++ b/shared/components/marketing/hero/Side.astro
@@ -58,7 +58,7 @@ const typedId = 'typed'
   <script is:inline define:vars={{ typedId, strings }}>
     // @ts-nocheck — typedId is used in a template literal, which the type checker resolves independently of define:vars.
     function initTyped() {
-      const typed = new Typed(`#${typedId}`, {
+      new Typed(`#${typedId}`, {
         strings,
         typeSpeed: 100,
         backSpeed: 50,
diff --git a/shared/layouts/BaseLayout.astro b/shared/layouts/BaseLayout.astro
index d2717fd93..619c977e7 100644
--- a/shared/layouts/BaseLayout.astro
+++ b/shared/layouts/BaseLayout.astro
@@ -193,7 +193,6 @@ const libJsFiles = (head: boolean) => pageLibEntries.filter(([, lib]) => Boolean
 
         resetButton.addEventListener('click', function () {
           for (var key in themeConfig) {
-            var value = themeConfig[key]
             document.documentElement.removeAttribute('data-bs-' + key)
             window.localStorage.removeItem('tabler-' + key)
             url.searchParams.delete(key)
diff --git a/shared/ui/AdvancedTable.astro b/shared/ui/AdvancedTable.astro
index 249cf8d21..e052b417d 100644
--- a/shared/ui/AdvancedTable.astro
+++ b/shared/ui/AdvancedTable.astro
@@ -177,10 +177,8 @@ const sortKeys = headers.map((header) => header['data-sort'])
     window.setPageListItems = function setPageListItems(el) {
       const id = el.closest('[data-table-id]')?.dataset.tableId
       if (!id || !window.tabler_list?.[id]) return
-
       window.tabler_list[id].page = parseInt(el.dataset.value)
       window.tabler_list[id].update()
-
       document.querySelector(`#${id}-page-count`).innerHTML = el.dataset.value
     }
 
diff --git a/shared/ui/Card.astro b/shared/ui/Card.astro
index c616dc7fc..3e15f17b6 100644
--- a/shared/ui/Card.astro
+++ b/shared/ui/Card.astro
@@ -1,9 +1,13 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // Composable card container (.card). For the fixed demo-showcase card see ../cards/Card.astro.
 
-interface Props {
-  /** element to render instead of div (e.g. form, a) */
-  as?: string
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   /** card-{size} body padding: sm | md | lg */
   size?: string
   class?: string
diff --git a/shared/ui/CardHeader.astro b/shared/ui/CardHeader.astro
index 2b86c2ea3..9ddc436c8 100644
--- a/shared/ui/CardHeader.astro
+++ b/shared/ui/CardHeader.astro
@@ -1,10 +1,14 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // Card header (.card-header) with an optional h3.card-title; slot renders after the title.
 
-interface Props {
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   title?: string
-  /** heading element for the title, e.g. h2 — default h3 */
-  as?: string
   /** card-header-light */
   light?: boolean
   class?: string
diff --git a/shared/ui/CardSubtitle.astro b/shared/ui/CardSubtitle.astro
index 24a73709d..ed702055e 100644
--- a/shared/ui/CardSubtitle.astro
+++ b/shared/ui/CardSubtitle.astro
@@ -1,9 +1,13 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // Card subtitle (.card-subtitle).
 
-interface Props {
-  /** element to render — default p */
-  as?: string
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   class?: string
 }
 
diff --git a/shared/ui/CardTitle.astro b/shared/ui/CardTitle.astro
index 2276ead8a..25f953ec7 100644
--- a/shared/ui/CardTitle.astro
+++ b/shared/ui/CardTitle.astro
@@ -1,9 +1,13 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // Standalone card title heading (.card-title), used inside a card body without a .card-header bar.
 
-interface Props {
-  /** heading element, e.g. h2 — default h3 */
-  as?: string
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   class?: string
   id?: string
 }
diff --git a/shared/ui/FormHint.astro b/shared/ui/FormHint.astro
index d3ea9f7fe..5c45c48d1 100644
--- a/shared/ui/FormHint.astro
+++ b/shared/ui/FormHint.astro
@@ -1,9 +1,13 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // Form hint text (.form-hint).
 
-interface Props {
-  /** element to render — default div */
-  as?: string
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   class?: string
   /** id so a control can reference the hint via aria-describedby */
   id?: string | undefined
diff --git a/shared/ui/ListGroup.astro b/shared/ui/ListGroup.astro
index 039c82d29..134a4ca22 100644
--- a/shared/ui/ListGroup.astro
+++ b/shared/ui/ListGroup.astro
@@ -1,9 +1,13 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // List group container (.list-group).
 
-interface Props {
-  /** element to render instead of div (e.g. ul, nav) */
-  as?: string
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   flush?: boolean
   hoverable?: boolean
   transparent?: boolean
diff --git a/shared/ui/ListGroupItem.astro b/shared/ui/ListGroupItem.astro
index dcbab7501..f60e8af86 100644
--- a/shared/ui/ListGroupItem.astro
+++ b/shared/ui/ListGroupItem.astro
@@ -1,9 +1,13 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // List group item (.list-group-item).
 
-interface Props {
-  /** element to render instead of div (e.g. a, li, label) */
-  as?: string
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   /** list-group-item-action (hover/focus affordance, typically for a/button items) */
   action?: boolean
   active?: boolean
diff --git a/shared/ui/Subheader.astro b/shared/ui/Subheader.astro
index f94d8c1c1..2d47ae6f7 100644
--- a/shared/ui/Subheader.astro
+++ b/shared/ui/Subheader.astro
@@ -1,9 +1,13 @@
 ---
+import type { HTMLTag } from 'astro/types'
+
 // Section subheader label (.subheader).
 
-interface Props {
-  /** element to render — default div */
-  as?: string
+// `as` must stay out of the Props body: Astro's frontmatter scanner bails on a member
+// literally named `as` and silently falls back to untyped props.
+type PolymorphicProps = { as?: HTMLTag }
+
+interface Props extends PolymorphicProps {
   class?: string
   /** remaining attributes (colspan, …) are forwarded */
   [key: string]: unknown