From 596237e8cc760293150c2fdc28dfd392d9930101 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Kuna?= <1282324+codecalm@users.noreply.github.com> Date: Wed, 17 Sep 2025 16:34:36 +0200 Subject: [PATCH] Accessibility and semantic improvements (#2488) --- preview/pages/form-layout.html | 32 +++++++------ preview/pages/job-listing.html | 4 +- preview/pages/marketing/real-estate.html | 2 +- preview/pages/settings.html | 15 +++--- preview/pages/signatures.html | 9 ++-- shared/includes/layout/footer.html | 24 +++++----- shared/includes/layout/navbar-menu.html | 4 +- shared/includes/layout/navbar-search.html | 2 +- shared/includes/layout/navbar-side.html | 6 +++ shared/includes/layout/navbar-toggler.html | 2 +- shared/includes/layout/navbar.html | 30 +++++++++--- shared/includes/layout/page-header.html | 6 +-- shared/includes/layout/skip-link.html | 2 + shared/includes/marketing/navbar.html | 54 +++++++++++----------- shared/includes/parts/nav/nav-aside.html | 4 +- shared/includes/settings.html | 4 +- shared/includes/ui/breadcrumb.html | 38 ++++++++------- shared/includes/ui/icon.html | 2 +- shared/includes/ui/pagination.html | 2 + shared/layouts/base.html | 1 + shared/layouts/default.html | 8 +++- shared/layouts/docs/default.html | 10 +++- shared/layouts/marketing.html | 11 ++++- shared/layouts/settings.html | 12 +++-- 24 files changed, 174 insertions(+), 110 deletions(-) create mode 100644 shared/includes/layout/skip-link.html diff --git a/preview/pages/form-layout.html b/preview/pages/form-layout.html index 32fb59eb9..96a7005e3 100644 --- a/preview/pages/form-layout.html +++ b/preview/pages/form-layout.html @@ -21,20 +21,24 @@ page-libs: [litepicker]
- + +
- + +
- + +
- + +
@@ -55,31 +59,31 @@ page-libs: [litepicker]
-
-
-
-
-
diff --git a/preview/pages/job-listing.html b/preview/pages/job-listing.html index 89fe0ba36..aecded73d 100644 --- a/preview/pages/job-listing.html +++ b/preview/pages/job-listing.html @@ -46,9 +46,9 @@ permalink: job-listing.html
Only show companies that can sponsor a visa
-
Location
+
- diff --git a/preview/pages/marketing/real-estate.html b/preview/pages/marketing/real-estate.html index e0cdc4416..cfbbfe237 100644 --- a/preview/pages/marketing/real-estate.html +++ b/preview/pages/marketing/real-estate.html @@ -12,7 +12,7 @@ permalink: marketing/real-estate.html
- +
diff --git a/preview/pages/settings.html b/preview/pages/settings.html index 2fe4675f7..3ec25b84a 100644 --- a/preview/pages/settings.html +++ b/preview/pages/settings.html @@ -19,16 +19,16 @@ permalink: settings.html
-
Business Name
- + +
-
Business ID
- + +
-
Location
- Location +
@@ -39,7 +39,8 @@ permalink: settings.html
- + +
{% include "ui/button.html" text="Change" %}
diff --git a/preview/pages/signatures.html b/preview/pages/signatures.html index d954ac929..ab6ce856c 100644 --- a/preview/pages/signatures.html +++ b/preview/pages/signatures.html @@ -66,12 +66,12 @@ document.querySelector("#signature-advanced-png").addEventListener("click", func

Please confirm the transfer of funds by signing below.

- - + +
- - + +
@@ -105,6 +105,7 @@ document.querySelector("#signature-advanced-png").addEventListener("click", func
+
diff --git a/shared/includes/layout/footer.html b/shared/includes/layout/footer.html index 01e0931b0..bb5df95e3 100644 --- a/shared/includes/layout/footer.html +++ b/shared/includes/layout/footer.html @@ -3,17 +3,19 @@
- +
+
{% include "cards/navbar-apps.html" %}
+
@@ -56,6 +60,7 @@
{% endunless %} +
Status Profile @@ -64,5 +69,6 @@ Settings Logout
+
diff --git a/shared/includes/layout/navbar-toggler.html b/shared/includes/layout/navbar-toggler.html index 6cf5a3669..66c5ebc9b 100644 --- a/shared/includes/layout/navbar-toggler.html +++ b/shared/includes/layout/navbar-toggler.html @@ -1,5 +1,5 @@ - \ No newline at end of file diff --git a/shared/includes/layout/navbar.html b/shared/includes/layout/navbar.html index c64cacfba..77f624003 100644 --- a/shared/includes/layout/navbar.html +++ b/shared/includes/layout/navbar.html @@ -18,20 +18,30 @@ {% if condensed %} {% endunless %} {% if include.sticky %} diff --git a/shared/includes/layout/page-header.html b/shared/includes/layout/page-header.html index 9abd762bd..fc19f66a2 100644 --- a/shared/includes/layout/page-header.html +++ b/shared/includes/layout/page-header.html @@ -9,7 +9,7 @@ {% if page-header-file %} {% include "layout/headers/{{ page-header-file }}.html" %} {% elsif page-header %} -
+
@@ -19,12 +19,12 @@ {{ pretitle }}
{% endif %} -

+

{% if page-icon %} {% include "ui/icon.html" icon=page-icon %} {% endif %} {{ page-header }} -

+ {% if description %}
{{ description }}
diff --git a/shared/includes/layout/skip-link.html b/shared/includes/layout/skip-link.html new file mode 100644 index 000000000..21b5332ad --- /dev/null +++ b/shared/includes/layout/skip-link.html @@ -0,0 +1,2 @@ + + diff --git a/shared/includes/marketing/navbar.html b/shared/includes/marketing/navbar.html index cc115ad33..2fff47a26 100644 --- a/shared/includes/marketing/navbar.html +++ b/shared/includes/marketing/navbar.html @@ -8,36 +8,38 @@ data-bs-target="#navbarTogglerDemo01" aria-controls="navbarTogglerDemo01" aria-expanded="false" - aria-label="Toggle navigation" + aria-label="Toggle primary navigation" >
diff --git a/shared/includes/parts/nav/nav-aside.html b/shared/includes/parts/nav/nav-aside.html index 40013e2dc..53148bce4 100644 --- a/shared/includes/parts/nav/nav-aside.html +++ b/shared/includes/parts/nav/nav-aside.html @@ -2,14 +2,14 @@
Category
{% assign items = "Games,Clothing,Jewelery,Toys" | split: "," %} -
+
+
Rating
{% assign items = "5 stars,4 stars,3 stars,2 and less stars" | split: "," %} diff --git a/shared/includes/settings.html b/shared/includes/settings.html index d999d2503..cbc955f7b 100644 --- a/shared/includes/settings.html +++ b/shared/includes/settings.html @@ -3,9 +3,9 @@ {% include "ui/icon.html" icon="brush" %} -
+
-

Theme Settings

+

Theme Settings

diff --git a/shared/includes/ui/breadcrumb.html b/shared/includes/ui/breadcrumb.html index 7dcfd7f56..c6172099b 100644 --- a/shared/includes/ui/breadcrumb.html +++ b/shared/includes/ui/breadcrumb.html @@ -1,20 +1,24 @@ {% assign breadcrumb-pages = include.pages | default: "Home,Library,Data" | split: "," -%} -
    - {%- for page in breadcrumb-pages -%} - {%- if forloop.last -%} -
  1. - {{ page }} -
    2. - {%- else -%} -
  2. - {% if forloop.first and include.home-icon-%} - - {% include "ui/icon.html" icon="home" %} - + +
+ + diff --git a/shared/includes/ui/icon.html b/shared/includes/ui/icon.html index c806648d9..2b4dabf96 100644 --- a/shared/includes/ui/icon.html +++ b/shared/includes/ui/icon.html @@ -27,5 +27,5 @@ {% assign svg-icon = icons[icon-name].svg[icon-type] | default: '' -%} {%- assign svg-icon = svg-icon | replace: '', '' -%} - {{ svg-icon | replace_regex: 'class=\"[^"]+\"', replace-to }} + {{ svg-icon | replace_regex: 'class=\"[^"]+\"', replace-to | replace: 'class="', 'aria-hidden="true" focusable="false" class="' }} {%- endif -%} diff --git a/shared/includes/ui/pagination.html b/shared/includes/ui/pagination.html index d07845d6e..997da8c41 100644 --- a/shared/includes/ui/pagination.html +++ b/shared/includes/ui/pagination.html @@ -2,6 +2,7 @@ {% assign offset = include.offset | default: count -%} {% assign count-offset = count | minus: offset | plus: 1 -%} {% assign active-item = include.active-item | default: 3 -%} +
    {% if include.first-last -%}
  • @@ -53,3 +54,4 @@
    • {% endif -%}
+ diff --git a/shared/layouts/base.html b/shared/layouts/base.html index a7b1913cc..7e7e01a47 100644 --- a/shared/layouts/base.html +++ b/shared/layouts/base.html @@ -45,6 +45,7 @@ {% assign layout-dark = layout-dark | default: site.layoutDark %} + {% include "layout/skip-link.html" %} diff --git a/shared/layouts/default.html b/shared/layouts/default.html index 2b77d81ba..876fc4cc4 100644 --- a/shared/layouts/default.html +++ b/shared/layouts/default.html @@ -18,10 +18,12 @@ layout: base {% endunless %}
+ {% include "layout/page-header.html" %} + -
+
{% if layout-wrapper-full %} {{ content }} {% else %} @@ -34,9 +36,11 @@ layout: base {% endunless %} {% endif %} -
+ + {% include "layout/footer.html" %} +
\ No newline at end of file diff --git a/shared/layouts/docs/default.html b/shared/layouts/docs/default.html index 1a268d610..a7a41b0b5 100644 --- a/shared/layouts/docs/default.html +++ b/shared/layouts/docs/default.html @@ -81,8 +81,13 @@ + +
{% include "docs/navbar.html" %} -
+
+ + +
@@ -154,7 +159,8 @@
-
+ + {% for lib in libs -%} {% if docs-libs contains lib[0] or libs.global-libs contains lib[0] or lib[0] == "clipboard" -%} diff --git a/shared/layouts/marketing.html b/shared/layouts/marketing.html index 40fab107d..435bab79f 100644 --- a/shared/layouts/marketing.html +++ b/shared/layouts/marketing.html @@ -3,11 +3,19 @@ layout: base body-class: body-marketing body-gradient plugins: marketing --- - + +
{% include "marketing/navbar.html" %} +
+ + +
{{ content }} +
+ +
@@ -162,3 +170,4 @@ plugins: marketing
+ diff --git a/shared/layouts/settings.html b/shared/layouts/settings.html index 247417962..19e3f11be 100644 --- a/shared/layouts/settings.html +++ b/shared/layouts/settings.html @@ -4,29 +4,31 @@ title: Settings page-header: Account Settings --- +

Business settings

-
+
+

Experience

-
+
+
{{ content }}
-
\ No newline at end of file +
+ \ No newline at end of file