From 75619ddf725b1eeb30a157e367cbfe0950ec3702 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Kuna?= <1282324+codecalm@users.noreply.github.com> Date: Sun, 14 May 2023 15:54:17 +0200 Subject: [PATCH] Unify dark mode with latest Bootstrap API and improve dark mode elements (#1561) --- .changeset/rare-pumpkins-pull.md | 5 + src/js/demo-theme.js | 7 +- src/pages/_includes/layout/navbar-logo.html | 4 +- src/pages/_includes/layout/navbar-search.html | 2 +- src/pages/_includes/layout/navbar-side.html | 7 - src/pages/_includes/layout/navbar.html | 14 +- src/pages/_includes/layout/sidebar.html | 4 +- src/pages/_includes/ui/dropdown-menu.html | 2 +- src/pages/_includes/ui/form/input-icon.html | 2 +- src/scss/_config.scss | 1 + src/scss/_variables-dark.scss | 17 ++ src/scss/_variables.scss | 19 +- src/scss/demo.scss | 12 +- src/scss/demo/_examples.scss | 16 -- src/scss/layout/_dark.scss | 208 ++++-------------- src/scss/layout/_navbar.scss | 52 ++--- src/scss/layout/_root.scss | 7 +- src/scss/mixins/_mixins.scss | 32 --- src/scss/ui/_tables.scss | 15 -- src/scss/vendor/_apexcharts.scss | 16 ++ src/scss/vendor/_tinymce.scss | 6 +- 21 files changed, 141 insertions(+), 307 deletions(-) create mode 100644 .changeset/rare-pumpkins-pull.md create mode 100644 src/scss/_variables-dark.scss diff --git a/.changeset/rare-pumpkins-pull.md b/.changeset/rare-pumpkins-pull.md new file mode 100644 index 000000000..9d6514ef5 --- /dev/null +++ b/.changeset/rare-pumpkins-pull.md @@ -0,0 +1,5 @@ +--- +"@tabler/core": minor +--- + +Unify dark mode with latest Bootstrap API and improve dark mode elements diff --git a/src/js/demo-theme.js b/src/js/demo-theme.js index e2479d8e6..bc258915e 100644 --- a/src/js/demo-theme.js +++ b/src/js/demo-theme.js @@ -21,5 +21,8 @@ if (!!params.theme) { selectedTheme = storedTheme ? storedTheme : defaultTheme } -document.body.classList.remove("theme-dark", "theme-light") -document.body.classList.add(`theme-${selectedTheme}`) +if (selectedTheme === 'dark') { + document.body.setAttribute("data-bs-theme", selectedTheme) +} else { + document.body.removeAttribute("data-bs-theme") +} \ No newline at end of file diff --git a/src/pages/_includes/layout/navbar-logo.html b/src/pages/_includes/layout/navbar-logo.html index 5d355e28f..84074cf41 100644 --- a/src/pages/_includes/layout/navbar-logo.html +++ b/src/pages/_includes/layout/navbar-logo.html @@ -11,9 +11,9 @@ {% endif %} {% unless include.hide-logo %} {% if include.small-logo %} - {{ site.title }} + {{ site.title }} {% else %} - {{ site.title }} + {{ site.title }} {% endif %} {% endunless %} diff --git a/src/pages/_includes/layout/navbar-search.html b/src/pages/_includes/layout/navbar-search.html index a3054a468..4db5c325f 100644 --- a/src/pages/_includes/layout/navbar-search.html +++ b/src/pages/_includes/layout/navbar-search.html @@ -2,6 +2,6 @@
- {% include ui/form/input-icon.html prepend=true dark=include.dark rounded=include.rounded aria-label="Search in website" %} + {% include ui/form/input-icon.html prepend=true rounded=include.rounded aria-label="Search in website" %}
diff --git a/src/pages/_includes/layout/navbar-side.html b/src/pages/_includes/layout/navbar-side.html index 53c8de0f6..2deff258e 100644 --- a/src/pages/_includes/layout/navbar-side.html +++ b/src/pages/_includes/layout/navbar-side.html @@ -5,17 +5,10 @@ {% unless include.condensed %} {% endunless %} diff --git a/src/pages/_includes/layout/navbar.html b/src/pages/_includes/layout/navbar.html index 7c380fc68..805708924 100644 --- a/src/pages/_includes/layout/navbar.html +++ b/src/pages/_includes/layout/navbar.html @@ -5,22 +5,22 @@
{% endif %} -