Run check:compat --strict in the Release workflow (#3123)

.github/workflows/build.yml

@@ -23,9 +23,9 @@ jobs:
       - name: Build
         run: pnpm exec turbo build
 
-      # Nothing the last release shipped may disappear in a minor release. The
-      # versions pull request runs it with --strict, so a release cannot be
-      # merged while compat-baseline.txt still lists a break nobody accepted.
+      # Nothing the last release shipped may disappear in a minor release. On the
+      # versions pull request it runs with --strict, but workflows there wait for
+      # a manual approval, so the Release workflow runs --strict too.
       - name: Check backward compatibility
         env:
           STRICT: ${{ github.head_ref == 'changeset-release/dev' && '--strict' || '' }}

.github/workflows/release.yml

@@ -35,6 +35,15 @@ jobs:
       - name: Build
         run: pnpm run build
 
+      # The last gate before npm: nothing the previous release shipped may be
+      # missing, unless compat-baseline.txt marks it as accepted. It runs here and
+      # not only on the versions pull request, because workflows on a pull request
+      # opened by the bot wait for a manual approval and may never run. On the
+      # push that publishes, the local version is not on npm yet, so the check
+      # compares with `latest`, which is the release users update from.
+      - name: Check backward compatibility
+        run: pnpm run check:compat --strict
+
       - name: Create release Pull Request or publish to NPM
         id: changesets
         uses: changesets/action@ae32849d5ba541f9ae29e40e22a623bc13562f51 # v2.1.2