mirror of
https://github.com/openwrt/luci.git
synced 2026-10-12 07:17:33 +04:00
Fuad Hasan
5c4e7afe71
normalize_assets() passes a string to match(), which requires a regexp and returns null for anything else. The path check therefore fails for every asset and each one is dropped by the following continue, so an auth plugin's scripts are never rendered on the login page. The failure is silent. The html returned by the same check() call is unaffected, so a plugin's login UI appears without the script that drives it and nothing is logged. plugins/luci-plugin-auth-example is affected as well. The check is a plain prefix test, so use index() rather than compiling a regexp per asset. It returns the offset of the first occurrence or -1, making != 0 the equivalent of the anchored ^, and comparing two plain strings keeps the check independent of how uuid is validated. Signed-off-by: Fuad Hasan <fuad.antor@gmail.com>