From 760fd341e3777019bcfcc5d20816216bd8b4d087 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Sun, 16 Aug 2026 15:18:56 -0700 Subject: [PATCH] treewide: remove fwnode_get_name in format strings Use %pfwP to proper type checking. Signed-off-by: Rosen Penev Link: https://github.com/openwrt/openwrt/pull/25141 Signed-off-by: Jonas Jelonek --- .../gpio-button-hotplug/src/gpio-button-hotplug.c | 3 +-- package/kernel/leds-gca230718/src/leds-gca230718.c | 13 ++++++------- package/kernel/leds-ws2812b/src/leds-ws2812b.c | 11 +++++------ target/linux/generic/files/drivers/net/phy/ar8327.c | 2 +- 4 files changed, 13 insertions(+), 16 deletions(-) diff --git a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c index 307827363f4..e6adb3af1ce 100644 --- a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c +++ b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c @@ -380,8 +380,7 @@ gpio_keys_get_devtree_pdata(struct device *dev) int irq; if (fwnode_property_read_u32(pp, "linux,code", &button->code)) { - dev_err(dev, "Button node '%s' without keycode\n", - fwnode_get_name(pp)); + dev_err(dev, "Button node '%pfwP' without keycode\n", pp); return ERR_PTR(-EINVAL); } diff --git a/package/kernel/leds-gca230718/src/leds-gca230718.c b/package/kernel/leds-gca230718/src/leds-gca230718.c index 352de61c2d4..29c0d912b05 100644 --- a/package/kernel/leds-gca230718/src/leds-gca230718.c +++ b/package/kernel/leds-gca230718/src/leds-gca230718.c @@ -122,13 +122,12 @@ static int gca230718_probe(struct i2c_client *client) i2c_set_clientdata(client, priv); device_for_each_child_node_scoped(&client->dev, ledNode) { - const char *lname = fwnode_get_name(ledNode); u32 regValue = 0; if (fwnode_property_read_u32(ledNode, "reg", ®Value)) - pr_info("Missing entry \"reg\" in node %s\n", lname); + pr_info("Missing entry \"reg\" in node %pfwP\n", ledNode); else if (regValue >= GCA230718_MAX_LEDS) - pr_info("Invalid entry \"reg\" in node %s (%u)\n", - lname, regValue); + pr_info("Invalid entry \"reg\" in node %pfwP (%u)\n", + ledNode, regValue); else { struct led_classdev *ledClassDev = &(priv->leds[regValue].ledClassDev); @@ -137,10 +136,10 @@ static int gca230718_probe(struct i2c_client *client) priv->leds[regValue].client = client; init_data.fwnode = fwnode_handle_get(ledNode); - pr_info("Creating LED for node %s: reg=%u\n", - lname, regValue); + pr_info("Creating LED for node %pfwP: reg=%u\n", + ledNode, regValue); - ledClassDev->name = lname; + ledClassDev->name = fwnode_get_name(ledNode); fwnode_property_read_string(ledNode, "label", &ledClassDev->name); ledClassDev->brightness = LED_OFF; diff --git a/package/kernel/leds-ws2812b/src/leds-ws2812b.c b/package/kernel/leds-ws2812b/src/leds-ws2812b.c index adb0899f1f4..4da7ad411f8 100644 --- a/package/kernel/leds-ws2812b/src/leds-ws2812b.c +++ b/package/kernel/leds-ws2812b/src/leds-ws2812b.c @@ -143,13 +143,13 @@ static int ws2812b_probe(struct spi_device *spi) ret = fwnode_property_read_u32(led_node, "reg", &cascade); if (ret) { - dev_err(dev, "failed to obtain numerical LED index for %s", - fwnode_get_name(led_node)); + dev_err(dev, "failed to obtain numerical LED index for %pfwP", + led_node); return ret; } if (cascade >= num_leds) { - dev_err(dev, "LED index of %s is larger than the number of LEDs.", - fwnode_get_name(led_node)); + dev_err(dev, "LED index of %pfwP is larger than the number of LEDs.", + led_node); return -EINVAL; } @@ -174,8 +174,7 @@ static int ws2812b_probe(struct spi_device *spi) ret = devm_led_classdev_multicolor_register_ext( dev, &priv->leds[cur_led].mc_cdev, &init_data); if (ret) { - dev_err(dev, "registration of %s failed.", - fwnode_get_name(led_node)); + dev_err(dev, "registration of %pfwP failed.", led_node); return ret; } cur_led++; diff --git a/target/linux/generic/files/drivers/net/phy/ar8327.c b/target/linux/generic/files/drivers/net/phy/ar8327.c index 0a6bd6a0fe8..90e278b2347 100644 --- a/target/linux/generic/files/drivers/net/phy/ar8327.c +++ b/target/linux/generic/files/drivers/net/phy/ar8327.c @@ -378,7 +378,7 @@ ar8327_leds_init(struct ar8xxx_priv *priv, struct fwnode_handle *leds) ret = fwnode_property_read_u32(child, "reg", ®); if (ret) { - pr_err("ar8327: LED %s is missing reg node\n", fwnode_get_name(child)); + pr_err("ar8327: LED %pfwP is missing reg node\n", child); continue; }