From 83a1dc91010f4251f183afa5d64422ca4b5eaefb Mon Sep 17 00:00:00 2001 From: Jonas Jelonek Date: Fri, 25 Sep 2026 00:01:50 +0000 Subject: [PATCH] realtek: pcs: rtl930x: read correct symbol errors for SGMII/1000Base-X Both modes were incorrectly assigned to the same branch that 10GBase-R and USXGMII use for reading the symbol error count. This behavior is not supported by anything in the SDK. According to that, they fall into the generic else case. Fix that by dropping those two modes from the branch condition. Signed-off-by: Jonas Jelonek --- .../linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c index d52970e8f22..961a264f003 100644 --- a/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c +++ b/target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c @@ -2886,10 +2886,8 @@ static u32 rtpcs_930x_sds_sym_err_get(struct rtpcs_serdes *sds, } else if (hw_mode == RTPCS_SDS_MODE_USXGMII && sds->usxgmii_submode == RTPCS_SDS_USXGMII_SM_10GQXGMII) { /* no known symbol error count for USXGMII QXGMII */ - } else if (hw_mode == RTPCS_SDS_MODE_1000BASEX || hw_mode == RTPCS_SDS_MODE_SGMII || - hw_mode == RTPCS_SDS_MODE_10GBASER || - (hw_mode == RTPCS_SDS_MODE_USXGMII && - sds->usxgmii_submode == RTPCS_SDS_USXGMII_SM_10GSXGMII)) { + } else if (hw_mode == RTPCS_SDS_MODE_10GBASER || (hw_mode == RTPCS_SDS_MODE_USXGMII && + sds->usxgmii_submode == RTPCS_SDS_USXGMII_SM_10GSXGMII)) { v = rtpcs_sds_read(sds, PAGE_TGR_STD_1, 0x1); v &= 0xff; } else {