From bb38f71acbb9e24d7bf69357b4271ae356be5d5b Mon Sep 17 00:00:00 2001
From: Chad Monroe <chad@monroe.io>
Date: Mon, 10 Aug 2026 20:00:59 -0700
Subject: [PATCH] mediatek: filogic: SDG-8733A: describe the LAN LEDs per
 hardware

The board has three LAN LEDs: white on GPIO 59, amber on GPIO 60
and green on GPIO 68. The old description listed two GPIO LEDs
with swapped colors and drove the green LED from the internal
2.5G PHY.

Describe all three as GPIO LEDs and set the netdev triggers to
match: white 2.5G, green 1G, amber 100M. Drop the PHY LED node
and the LED pinctrl state: the PHY LED pad (2p5gbe_led0, pin 68)
now works as the green LED GPIO, so the PHY drives no LED.

Signed-off-by: Chad Monroe <chad@monroe.io>
Link: https://github.com/openwrt/openwrt/pull/24352
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
---
 .../dts/mt7988d-smartrg-SDG-8733A.dts         | 30 ++++++-------------
 .../filogic/base-files/etc/board.d/01_leds    |  2 +-
 2 files changed, 10 insertions(+), 22 deletions(-)

diff --git a/target/linux/mediatek/dts/mt7988d-smartrg-SDG-8733A.dts b/target/linux/mediatek/dts/mt7988d-smartrg-SDG-8733A.dts
index b67e427911e..1c76fdf6941 100644
--- a/target/linux/mediatek/dts/mt7988d-smartrg-SDG-8733A.dts
+++ b/target/linux/mediatek/dts/mt7988d-smartrg-SDG-8733A.dts
@@ -74,17 +74,23 @@
 	leds: gpio-leds {
 		compatible = "gpio-leds";
 
-		lan_amber {
-			color = <LED_COLOR_ID_GREEN>;
+		lan_white {
+			color = <LED_COLOR_ID_WHITE>;
 			function = "lan";
 			gpios = <&pio 59 GPIO_ACTIVE_HIGH>;
 		};
 
-		lan_green {
+		lan_amber {
 			color = <LED_COLOR_ID_AMBER>;
 			function = "lan";
 			gpios = <&pio 60 GPIO_ACTIVE_HIGH>;
 		};
+
+		lan_green {
+			color = <LED_COLOR_ID_GREEN>;
+			function = "lan";
+			gpios = <&pio 68 GPIO_ACTIVE_HIGH>;
+		};
 	};
 
 	thermal-zones {
@@ -135,17 +141,6 @@
 	status = "okay";
 };
 
-&int_2p5g_phy {
-	pinctrl-names = "i2p5gbe-led";
-	pinctrl-0 = <&i2p5gbe_led0_pins>;
-};
-
-&i2p5gbe_led0 {
-	color = <LED_COLOR_ID_GREEN>;
-	function = LED_FUNCTION_LAN;
-	status = "okay";
-};
-
 &mdio_bus {
 	reset-gpios = <&pio 62 GPIO_ACTIVE_LOW>;
 	reset-delay-us = <100000>;
@@ -192,13 +187,6 @@
 };
 
 &pio {
-	i2p5gbe_led0_pins: 2p5gbe-led0-pins {
-		mux {
-			function = "led";
-			groups = "2p5gbe_led0";
-		};
-	};
-
 	pcie0_1_pins: pcie0-pins-g1 {
 		mux {
 			function = "pcie";
diff --git a/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds b/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds
index ef3975c15af..df3ca434847 100644
--- a/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds
+++ b/target/linux/mediatek/filogic/base-files/etc/board.d/01_leds
@@ -306,7 +306,7 @@ smartrg,sdg-8734)
 	ucidef_set_led_netdev "wan-white" "WAN" "mdio-bus:00:white:wan" "wan" "link_10000"
 	;;
 smartrg,sdg-8733a)
-	ucidef_set_led_netdev "lan-green-act" "LAN" "mdio-bus:0f:green:lan" "lan" "link_2500"
+	ucidef_set_led_netdev "lan-white" "LAN" "white:lan" "lan" "link_2500"
 	ucidef_set_led_netdev "lan-amber" "LAN" "amber:lan" "lan" "link_100"
 	ucidef_set_led_netdev "lan-green" "LAN" "green:lan" "lan" "link_1000"
 	ucidef_set_led_netdev "wan-green" "WAN" "mdio-bus:08:green:wan" "wan" "link_2500 link_5000"