mirror of
https://github.com/openwrt/openwrt.git
synced 2026-10-13 17:38:48 +04:00
Joshua Covington
3cdb8b59d9
videobuf2-vmalloc.ko was listed unconditionally in video-videobuf2's FILES, but CONFIG_VIDEOBUF2_VMALLOC is only reliably built when a driver that needs a vmalloc-backed allocator (e.g. pwc, uvc, gspca) is itself selected. Any build where none of those drivers happen to be enabled (e.g. under CONFIG_ALL_KMODS=y on a target where those USB webcam drivers aren't selected) fails hard while packaging kmod-video-videobuf2, since the .ko it expects to copy was never built: ERROR: module '.../videobuf2-vmalloc.ko' is missing. Split it out into its own kmod-video-vmalloc package, following the same pattern already used for video-dma-contig and video-dma-sg. videobuf2-vmalloc.c calls dma_buf_vmap_unlocked/dma_buf_vunmap_unlocked directly, so the new package depends on kmod-dma-buf explicitly rather than only transitively through kmod-video-videobuf2. Adjust the DEPENDS of all six in-tree drivers that previously got the module for free from kmod-video-videobuf2: video-pwc, video-uvc, video-gspca-core, video-coda, video-tw686x and camera-bcm2835. camera-bcm2835's AUTOLOAD priority also moves from 66 to 67, matching its siblings bcm2835-codec/bcm2835-isp/rp1-cfe*, which already sit one priority above the videobuf2 allocator helper (65/66) they depend on. Fix also two dead entries in video-videobuf2's AUTOLOAD that never matched a built module (videobuf2-core and videobuf-v4l2, vs. the actual videobuf2-common.ko/videobuf2-v4l2.ko), which caused kmodloader to complain on every boot; pre-existing, unrelated to the split itself. Signed-off-by: Joshua Covington <joshuacov@gmail.com> Link: https://github.com/openwrt/openwrt/pull/24647 Signed-off-by: Robert Marko <robimarko@gmail.com>