mirror of
https://github.com/openwrt/openwrt.git
synced 2026-10-12 06:57:57 +04:00
Felix Fietkau
5fe8fade02
A subscriber that reports the BSS colours of a radio needs three fields: the BSS Color subfield and the Partial BSS Color subfield that the radio transmits, and the colours of the OBSSs that the AP identified itself or learnt from the BSS Color Collision reports of its stations. get_status named the colour, as -1 while BSS Color is disabled, and neither of the others. hostapd kept its colours in use per BSS, and each collision event replaced them. It also added the colour of a BSS Color In Use report, which names a colour a station uses with a peer (IEEE Std 802.11-2024 11.21.2.8), not an OBSS colour. 174-ap-keep-the-obss-colors-of-a-radio keeps two sets per radio: - the OBSS colours, which the kernel's collision events and the BSS Color Collision reports of stations add to. A colour leaves the set 60 s after an event named it, or 130 s after a report did (the longest dot11BSSColorCollisionSTAPeriod, 120 s, plus a 10 s margin), and the ageing pauses while BSS Color is disabled; - the colours of BSS Color In Use reports, held per station until a report of colour 0 or until the station leaves. A colour change picks a colour outside both sets. get_status now adds, beside bss_color, at the top level and in each entry of the links of an AP MLD: - he_bss_color: the BSS Color subfield of the HE Operation element. It keeps the colour while BSS Color is disabled (IEEE Std 802.11-2024 26.11.4); bss_color keeps -1 then; - bss_color_partial: he_bss_color_partial of the radio; - bss_colors_in_use: the OBSS colours of the radio, 1 to 63. The colours of BSS Color In Use reports are not among them. On mt76 the kernel's collision events name the colliding colour only: mt7996 does not detect collisions itself, and mac80211 (ieee80211_rx_check_bss_color_collision()) reports an OBSS whose colour equals the BSS's own. Other OBSS colours reach the set only through the BSS Color Collision reports of stations. The colours are a list rather than the 64-bit bitmap, because a blobmsg int64 with bit 63 set reads as a negative number in ucode and JSON. Signed-off-by: Felix Fietkau <nbd@nbd.name>