From 525182892b4e2a902b3f66eea1b3f4aa65da695a Mon Sep 17 00:00:00 2001 From: Miguel Angel Mulero Martinez Date: Tue, 16 Apr 2024 15:53:29 +0200 Subject: [PATCH] ddns-scripts: fix duplication of processes when reloading When a "service ddns reload" is issued, the ddns processes are being duplicated. It seems the culprit is the -1 in the 'killall' command, and removing it fixes the issue. The -1 means to use SIGHUP, instead of the default SIGTERM. In this case, the idea is to kill all other processes, so SIGTERM is appropriate. In case the processes hang, SIGKILL may be another option. Signed-off-by: Miguel Angel Mulero Martinez --- net/ddns-scripts/Makefile | 2 +- net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ddns-scripts/Makefile b/net/ddns-scripts/Makefile index 9ffc3d2f3b..2524188aa9 100644 --- a/net/ddns-scripts/Makefile +++ b/net/ddns-scripts/Makefile @@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=ddns-scripts PKG_VERSION:=2.8.2 -PKG_RELEASE:=43 +PKG_RELEASE:=44 PKG_LICENSE:=GPL-2.0 diff --git a/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh b/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh index 71de1a7e01..21b0202d37 100644 --- a/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh +++ b/net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh @@ -89,7 +89,7 @@ case "$1" in exit 1 ;; reload) - killall -1 dynamic_dns_updater.sh 2>/dev/null + killall dynamic_dns_updater.sh 2>/dev/null exit $? ;; *) usage_err "unknown command - $1";;