openwrt-mirror/packages
1
0
Fork 0
mirror of https://github.com/openwrt/packages.git synced 2025-12-21 21:24:31 +04:00
Code Issues Packages Projects Releases Wiki Activity

rsync: run as regular user rather than as root

Browse Source 
Rsyncd only needs a subset of all capabilities so create
a dedicated user with these capabilities. This is better from both a
security and an isolation perspective than running as root.

Build system: x86/64
Build-tested: x86/64-glibc
Run-tested: x86/64-glibc

Signed-off-by: John Audia <therealgraysky@proton.me>
This commit is contained in:
John Audia
2025-07-20 11:54:49 -04:00
committed by Hannu Nyman
parent e4ec9e371b
commit 2a7364534e
3 changed files with 48 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
net/rsync/Makefile
View File

@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
PKG_NAME:=rsync PKG_NAME:=rsync
PKG_VERSION:=3.4.1 PKG_VERSION:=3.4.1
PKG_RELEASE:=1 PKG_RELEASE:=2
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=https://download.samba.org/pub/$(PKG_NAME)/src PKG_SOURCE_URL:=https://download.samba.org/pub/$(PKG_NAME)/src
@@ -67,6 +67,7 @@ define Package/rsyncd
SUBMENU:=File Transfer SUBMENU:=File Transfer
TITLE:=Rsync daemon TITLE:=Rsync daemon
DEPENDS:=+rsync DEPENDS:=+rsync
USERID:=rsyncd=976:rsyncd=976
URL:=https://rsync.samba.org/ URL:=https://rsync.samba.org/
endef endef
@@ -108,6 +109,8 @@ define Package/rsyncd/install
$(INSTALL_DATA) ./files/rsyncd.conf $(1)/etc/ $(INSTALL_DATA) ./files/rsyncd.conf $(1)/etc/
$(INSTALL_DIR) $(1)/etc/init.d $(INSTALL_DIR) $(1)/etc/init.d
$(INSTALL_BIN) ./files/rsyncd.init $(1)/etc/init.d/rsyncd $(INSTALL_BIN) ./files/rsyncd.init $(1)/etc/init.d/rsyncd
$(INSTALL_DIR) $(1)/etc/capabilities
$(INSTALL_DATA) ./files/rsyncd.json $(1)/etc/capabilities
endef endef
define Package/rrsync/description define Package/rrsync/description

7
net/rsync/files/rsyncd.init
View File

@@ -10,5 +10,12 @@ PROG=/usr/bin/rsync
start_service() { start_service() {
procd_open_instance procd_open_instance
procd_set_param command "$PROG" --daemon --no-detach procd_set_param command "$PROG" --daemon --no-detach
[ -x /sbin/ujail -a -e /etc/capabilities/rsyncd.json ] && {
procd_add_jail rsyncd
procd_set_param capabilities /etc/capabilities/rsyncd.json
procd_set_param user rsyncd
procd_set_param group rsyncd
procd_set_param no_new_privs 1
}
procd_close_instance procd_close_instance
} }

37
net/rsync/files/rsyncd.json Normal file
View File

@@ -0,0 +1,37 @@
{
"bounding": [
"CAP_NET_BIND_SERVICE",
"CAP_SYS_CHROOT",
"CAP_SETUID",
"CAP_SETGID",
"CAP_DAC_OVERRIDE"
],
"effective": [
"CAP_NET_BIND_SERVICE",
"CAP_SYS_CHROOT",
"CAP_SETUID",
"CAP_SETGID",
"CAP_DAC_OVERRIDE"
],
"ambient": [
"CAP_NET_BIND_SERVICE",
"CAP_SYS_CHROOT",
"CAP_SETUID",
"CAP_SETGID",
"CAP_DAC_OVERRIDE"
],
"permitted": [
"CAP_NET_BIND_SERVICE",
"CAP_SYS_CHROOT",
"CAP_SETUID",
"CAP_SETGID",
"CAP_DAC_OVERRIDE"
],
"inheritable": [
"CAP_NET_BIND_SERVICE",
"CAP_SYS_CHROOT",
"CAP_SETUID",
"CAP_SETGID",
"CAP_DAC_OVERRIDE"
]
}