openwrt-mirror/packages
1
0
Fork 0
mirror of https://github.com/openwrt/packages.git synced 2025-12-21 19:14:30 +04:00
Code Issues Packages Projects Releases Wiki Activity

net-snmp: fix literal string test in snmpd_sink_add

Browse Source 
The function snmpd_sink_add() has a guard clause that tests the literal
string "section", not the variable value "$section".

The test `[ -n "section" ]` always evaluates to true because the string
literal "section" is non-empty, making the check useless.

This function is only called internally with hardcoded arguments, so the
bug has no actual impact currently. For the same reason, this change
should not break existing configurations. However, I think it should be
fixed so future callers do not have a false sense of security.

Signed-off-by: Eric McDonald <librick-openwrt@proton.me>
This commit is contained in:
Eric McDonald
2025-12-04 09:48:16 -08:00
committed by Stijn Tintel
parent 65d83de7f8
commit 93983e5b2a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/net-snmp/files/snmpd.init
View File

@@ -233,7 +233,7 @@ snmpd_sink_add() {
local host local host
config_get host "$cfg" host config_get host "$cfg" host
[ -n "section" -a -n "$host" ] || return 0 [ -n "$section" -a -n "$host" ] || return 0
# optional community # optional community
config_get community "$cfg" community config_get community "$cfg" community
# optional port # optional port