openwrt-mirror/packages
1
0
Fork 0
mirror of https://github.com/openwrt/packages.git synced 2025-12-21 23:34:31 +04:00
Code Issues Packages Projects Releases Wiki Activity

isc-dhcpd: quote filenames for safety

Browse Source 
Per best practices, we should protect against wildcards in
variable expansions.

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
This commit is contained in:
Philip Prindeville
2025-08-08 21:48:06 -06:00
parent 824a344a4a
commit ae8a2d515d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
net/isc-dhcp/files/dhcpd.init
View File

@@ -638,7 +638,7 @@ start_service() {
else else
. /lib/functions/network.sh . /lib/functions/network.sh
local dyn_file=$(mktemp -u /tmp/dhcpd.XXXXXX) local dyn_file="$(mktemp -u /tmp/dhcpd.XXXXXX)"
config_load dhcp config_load dhcp
@@ -653,7 +653,7 @@ start_service() {
general_config > $config_file general_config > $config_file
if [ $dynamicdns -eq 1 ]; then if [ $dynamicdns -eq 1 ]; then
cat <<EOF > $dyn_file cat <<EOF > "$dyn_file"
; Generated by /etc/init.d/dhcpd at $(date) ; Generated by /etc/init.d/dhcpd at $(date)
ttl $TTL ttl $TTL
@@ -681,11 +681,11 @@ EOF
no_ipv6 && args="-4" no_ipv6 && args="-4"
nsupdate -l -v $args $dyn_file nsupdate -l -v $args "$dyn_file"
fi fi
rm -f $dyn_file rm -f "$dyn_file"
[ -z "$dhcp_ifs" ] && return 0 [ -z "$dhcp_ifs" ] && return 0
fi fi