mirror of
https://github.com/openwrt/packages.git
synced 2025-12-21 21:24:31 +04:00
github: Use Markdown and slight changes to PR template
The previous pull request was kinda not exactly tested.
This one should be better and more visible.
Fixes: 9a273c3e79 ("github: Improve Pull Request template")
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
This commit is contained in:
19
.github/pull_request_template
vendored
19
.github/pull_request_template
vendored
@@ -1,19 +0,0 @@
|
|||||||
**Package details**
|
|
||||||
|
|
||||||
Maintainer: @\<github-user> (find it by checking the history of the package Makefile)
|
|
||||||
Description:
|
|
||||||
|
|
||||||
**Indication of run testing**
|
|
||||||
|
|
||||||
OpenWrt version:
|
|
||||||
OpenWrt target/subtarget:
|
|
||||||
OpenWrt device:
|
|
||||||
|
|
||||||
**Formalities**
|
|
||||||
|
|
||||||
[ ] Review the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines.
|
|
||||||
|
|
||||||
If your PR contains a patch
|
|
||||||
[ ] Make sure that it can be applied by `git am`
|
|
||||||
[ ] It must be refreshed to avoid offsets, fuzzes, etc by `make package/foo/refresh V=s`
|
|
||||||
[ ] It must be in a way that it is potentially upstreamable (subject, commit description, etc.), and we must try to upstream it so we have fewer patches and fewer.
|
|
||||||
32
.github/pull_request_template.md
vendored
Normal file
32
.github/pull_request_template.md
vendored
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
## 📦 Package Details
|
||||||
|
|
||||||
|
**Maintainer:** @<github-user>
|
||||||
|
<sub>(You can find this by checking the history of the package `Makefile`.)</sub>
|
||||||
|
|
||||||
|
**Description:**
|
||||||
|
<!-- Briefly describe what this package does or what changes are introduced -->
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 🧪 Run Testing Details
|
||||||
|
|
||||||
|
- **OpenWrt Version:**
|
||||||
|
- **OpenWrt Target/Subtarget:**
|
||||||
|
- **OpenWrt Device:**
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## ✅ Formalities
|
||||||
|
|
||||||
|
- [ ] I have reviewed the [CONTRIBUTING.md](../CONTRIBUTING.md) file for detailed contributing guidelines.
|
||||||
|
|
||||||
|
### If your PR contains a patch:
|
||||||
|
|
||||||
|
- [ ] It can be applied using `git am`
|
||||||
|
- [ ] It has been refreshed to avoid offsets, fuzzes, etc., using
|
||||||
|
```bash
|
||||||
|
make package/<your-package>/refresh V=s
|
||||||
|
```
|
||||||
|
- [ ] It is structured in a way that it is potentially upstreamable
|
||||||
|
<sub>(e.g., subject line, commit description, etc.)</sub>
|
||||||
|
<sub>We must try to upstream patches to reduce maintenance burden.</sub>
|
||||||
Reference in New Issue
Block a user