As Hannu Nyman pointed out, in some cases the build of the package is
able to fail:
Package snapserver is missing dependencies for the following libraries:
libasound.so.2
He said: on some build runs, alsa is built (as required by other
packages), and if it is built before snapcast, it may be detected,
if the feature is not explicitly disabled in CMakeLists.txt.
Also: "I think that you could drop that AUDIO_SUPPORT conditional.
AUDIO_SUPPORT is selected e.g. if USB_SUPPORT is selected,
so it is not that big restriction."
Suggested-by: Hannu Nyman <hannu.nyman@iki.fi>
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
Sort CMAKE_OPTIONS by alphabet and save a few bytes with tab character,
instead of repeating "CMAKE_OPTIONS +="
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
With "-DBUILD_WITH_AVAHI=OFF" the "libavahi-client" dependency is not
needed anymore. Instead, the "libexpat" dependency needs to be specified
explicitly.
Fixes: a9ac8666da ("snapcast: fix PulseAudio")
Fixes: eeb8d131fc ("snapcast: add package snapserver and snapclient")
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
snapserver has a built-in webserver which is able to host a web player:
snapweb. [1]
It is accessible at http://snapserver:1780/ but with enabled "doc_root"
setting and with missing directory the browser shows an empty page
with a message: "The resource '/' was not found."
Fix this with disabling the "doc_root" setting in "/etc/snapserver.conf"
This "doc_root" was enabled and set to "/usr/share/snapserver/snapweb"
in upstream commit fcbe40585875 ("Install snapweb") [2], back in 2020
and released in v0.21.0 of Snapcast.
This was reported in an upstream discussion by Robert Muth. [3]
[1]: https://github.com/badaix/snapweb
[2]: fcbe405858
[3]: https://github.com/badaix/snapcast/discussions/1417#discussioncomment-14480178
Fixes: eeb8d131fc ("snapcast: add package snapserver and snapclient")
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
While testing my integration of Snapcast, I didn't test with CONFIG_ALL*
and CONFIG_BUILDBOT flags, but the buildbots did and failed with a lot
of undefined reference to PulseAudio.
Fix it with preventing PulseAudio detection.
While at it, prevent Avahi detection too to save more flash space.
These features will be available later, through flavours.
Fixes: https://github.com/openwrt/packages/pull/23956
Fixes: eeb8d131fc ("snapcast: add package snapserver and snapclient")
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
Boost upgrade hit Snapcast hard again: the process needs to be updated!
This patch is a patchset from badaix/snapcast@develop.
It is based on the following upstream commits:
badaix/snapcast@901b79a213 ("Build failure with boost 1.88.0 #1367")
badaix/snapcast@ffb086b4b3 ("Define BOOST_PROCESS_VERSION=1 globally")
badaix/snapcast@c37a76a4ab ("Add missing includes")
badaix/snapcast@571f6a8f69 ("Include process v1 headers for Boost version >= v1.88.0")
Refs: 3585ddfc44 ("boost: Updates package to version 1.88.0")
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
After revisiting the PR, it didn't even compile because of commit
c50de920a2 ("boost: Updates package to version 1.87.0").
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
Snapcast [1] is a multiroom client-server audio player, where all
clients are time synchronized with the server to play perfectly synced
audio.
It's not a standalone player, but an extension that turns your existing
audio player into a Sonos-like multiroom solution.
Audio is captured by the server and routed to the connected clients.
Several players can feed audio to the server in parallel and clients can
be grouped to play the same audio stream.
One of the most generic ways to use Snapcast is in conjunction with the
music player daemon (MPD) [2] or Mopidy [3].
The inclusion starts with version 0.28.0 because of OpenSSL dependency
issues of version 0.29.0. Newer versions (e.g. 0.32.3, see [4])
with optional OpenSSL support, will be incorporated with flavours,
like "-mini" and "-full" in the upcoming PRs.
More about this topic please check the inclusion PR at [5]!
[1]: https://github.com/badaix/snapcast
[2]: http://www.musicpd.org/
[3]: https://www.mopidy.com/
[4]: https://github.com/badaix/snapcast/blob/develop/changelog.md
[5]: https://github.com/openwrt/packages/pull/23956#discussion_r2330463363Fixes: #23924
Suggested-by: Tianling Shen <cnsztl@immortalwrt.org>
Suggested-by: George Sapkin <george@sapk.in>
Signed-off-by: Szabolcs Hubai <szab.hu@gmail.com>
