Add `.github/llm-review-rules.md` to define project-specific patterns
and guidelines for the LLM review bot, alongside the equivalents in
openwrt/openwrt and openwrt/luci.
The rules cover what the review routine cannot infer from the diff
alone: quilt-managed patch refresh, the generic version check and the
test.sh / test-version.sh overrides, procd init scripts, conffiles
layout, source and mirror macro preferences, and Makefile indentation
per block type.
They also set the review posture. Formatting that changes what gets
built is treated as a defect, while cosmetic style is not worth
blocking a merge over; findings the formality bot already posts are
not repeated; and CI results are a reference rather than a gate.
Patches only need to be upstream-ready when they are candidates for
upstream, since many here are OpenWrt-specific hacks with nowhere to
go. Stable branches may carry a minor LTS update that has no
counterpart on master, so not every stable-branch PR is a cherry-pick.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Implement a nightly LLM review workflow that triggers
a reusable digest workflow from openwrt/actions-shared-workflows.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
While at it, we synchronized .github/formalities.json with the current
default settings of the webhook bot.
Since the bot is shared across all OpenWrt repositories, the stale PR
cleanup is disabled by default at the repository level. Because this
repository wants to use stale triage, we explicitly enable it here.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
- Change trigger back to pull_request to ensure it runs correctly on fork PRs
- Add a wait-for-formalities job that polls the GITHUB_TOKEN for FormalityCheck status
- Execute the feeds package test build only when the formalities check succeeds
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
- Change trigger from check_run to check_suite completed event
- Run feeds test build only when all checks in the suite succeed
Fixes: ef633e9 ("ci: replace GitHub actions (labeler, formalities) by webhook")
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
- Added file .github/formalities.json, which can be configured
in this repository, otherwise it uses defaults.
- Removed GitHub Action Labeler workflow as it was implemented
by webhook to be faster
- Updated multi-arch-test-build.yml to run builds when Formalities Check passes
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Refactor the PR labeler workflow to checkout the base repository ref
instead of the pull request head ref from forks, resolving checkout
errors inside the pull_request_target context.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
When a contributor pushes a new commit to an open PR, the previous
Test and Build run is no longer informative and only consumes a
runner slot that the new run could use. Add a concurrency group
keyed on the workflow name and ref so a fresh push cancels the
prior in-progress run for the same PR.
Since this workflow only triggers on pull_request, the ref is
always refs/pull/<num>/merge (unique per PR), so cancel-in-progress
can be set unconditionally.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Add a recurring workflow that runs every day at 5:30 and marks all PRs
that have formality check failures (i.e. marked as 'not following
guidelines') that have not been active in the past 14 days as stale.
Close stale PRs after 14 more days.
Signed-off-by: George Sapkin <george@sapk.in>
Add dependabot config to automatically check for action updates once a
week and open PRs if any are found.
Signed-off-by: George Sapkin <george@sapk.in>
Add 'Add package' label when a new Makefile is added or 'Drop package'
when a Makefile is deleted.
Label PRs to OpenWrt 25.12 branch.
Label CI-related PRs.
Signed-off-by: George Sapkin <george@sapk.in>
Disable posting formality check status comments and adding related
labels while the security token is being figured out.
Link: https://github.com/openwrt/packages/pull/28011
Fixes: 2c558a8 ("ci: label formality failures")
Fixes: 7658669 ("multi-arch-test-build: post formal summaries to PR")
Signed-off-by: George Sapkin <george@sapk.in>
Label based on target release branch. Labels must be manually defined to
avoid giving the action unnecessary permissions. Release labels must be
defined in the config after each release is forked.
Signed-off-by: George Sapkin <george@sapk.in>
Most of the time, when people contribute to the repository for the first time
(or after a longer break), the multi-arch-test-build passes, but the
formality check fails and requires the contributor to make some changes.
This creates unnecessary load on the CI/CD, since the multi-arch-test-build
runs again even though it already passed, while other PRs are waiting for a runner.
Hopefully, this change will help decrease the waiting time.
Proposed changes:
- Run the formality check first, and only trigger the package tests afterwards.
This can be done using needs: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idneeds
- Merge formal.yml into multi-arch-test-build.yml so that needs can be used.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Not everyone filling out the bug report is an expert.
These fields, with additional explanations, can hopefully
help users provide more accurate information.
Add fields to guide users in completing the bug report.
Signed-off-by: Wesley Gimenes <wehagy@proton.me>
Previously, users could leave fields blank,
resulting in missing information in the bug report.
Now, it is mandatory for all fields to be filled out,
ensuring that no essential information is overlooked.
Signed-off-by: Wesley Gimenes <wehagy@proton.me>
This replaces the old issue templates with the new one.
It is going to reflect changes and require more details.
Issue Forms as also used in the main repository and in LuCI,
it helps users to create structured issue.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
The previous pull request was kinda not exactly tested.
This one should be better and more visible.
Fixes: 9a273c3e79 ("github: Improve Pull Request template")
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
By updating pull request template, this ensures that all newly patches
will be hopefully submitted to upstream, which help us that we dont need to
maintain these patches for ages. Also, all patches should be applied by git am.
This is important, because this follows OpenWrt main repo contribution policy
and we will know, who is the author of the patch and what it does (=
commit subject, commit description).
Also, we don't need to know on which host env, we compiled package.
If there is something host related, we can request details.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
This change follows the structure of GitHub workflow
folders from the main OpenWrt repository, where scripts
are in separate folder.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Lets switch to shared workflow in actions-shared-workflows instead of having
this separate file here. It will track and use the latest changes to avoid
being outdated.
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Using -ne wasn't such a good idea since it would do a numeric compare.
Now use -n which checks if the length is non-zero. APK prints the
problematic version if - problematic - so this should now do the trick.
Signed-off-by: Paul Spooren <mail@aparcar.org>
This action was mostly based on the autorelease CI job and somehow there
is an error that if multiple packages are affected, the path is
concatenated instead of adding a space.
Secondly the APK return code 0 wasn't good enough for the if condition
and caused it to trigger even on valid versions.
Signed-off-by: Paul Spooren <mail@aparcar.org>
APK uses a deterministic version schema, have the CI check that changed
packages actually follow that version schema.
Signed-off-by: Paul Spooren <mail@aparcar.org>
With the commit 01e5cfc "CI: Add target/arch tags (no suffix) for
snapshot images"[1] the os/platform is set for all images, which is usually
different from what the GitHub action runner uses (x86). The Docker
deamon still tries to fetch the x86 version and fails.
This commit explicitly sets the fitting arch.
[1]: https://github.com/openwrt/docker/commit/01e5cfccd73a72ecab730496607c7c22b904f366
Signed-off-by: Paul Spooren <mail@aparcar.org>
dependabot[bot]
Josef SchlehoferandClaude Opus 5
Hauke MehrtensandClaude Opus 4.7
George Sapkin
Wesley Gimenes
Paul Spooren
Christian Marangi
Daniel Golle
Tianling Shen
Yegor Yefremov