From 2fe4311dbc0f4046285ed22155e221f56c5e4f51 Mon Sep 17 00:00:00 2001 From: Josef Schlehofer Date: Thu, 6 Aug 2026 14:13:40 +0200 Subject: [PATCH] naywatch: correct the reason recorded in test-version.sh The comment claimed the version check has to be skipped because running the script may trigger a reboot. That is not what happens: reboot_now() is only reached once naywatch has seen a neighbour (ACTIVE=1) and then lost it for more than MIN_KICK intervals, and the watchdog branch is not taken either, because the probe leaves use_watchdog empty. What does happen is that naywatch takes positional arguments - check interval, watchdog timeout, and so on - rather than options, so a probe flag ends up as the check interval and the script enters its monitoring loop instead of reporting anything, until the probe timeout kills it. The override stays, only its justification is corrected. Signed-off-by: Josef Schlehofer Co-authored-by: Claude Fable 5 --- naywatch/test-version.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/naywatch/test-version.sh b/naywatch/test-version.sh index 6e43575..d8b577e 100644 --- a/naywatch/test-version.sh +++ b/naywatch/test-version.sh @@ -4,9 +4,11 @@ case "$PKG_NAME" in naywatch) - # naywatch is a watchdog shell script which does not provide any - # option to report its version. It must not be executed during - # the CI runtime tests, since it may trigger a reboot. + # naywatch takes positional arguments (check interval, watchdog + # timeout, ...), not options, so a probe flag ends up as the + # check interval and the script enters its monitoring loop + # instead of reporting anything, until the probe timeout kills + # it. exit 0 ;;