mirror of
https://github.com/openwrt/luci.git
synced 2026-10-12 05:07:26 +04:00
luci-app-ddns: use array form of system() for invocations with user values
Convert system() calls in killcmd() and get_services_status from
string interpolation to the array form to avoid shell interpretation
of user-controlled procid, signal, lookupHost, section, and dnsServer
parameters.
(cherry picked from commit 80a3b58eed)
This commit is contained in:
1 parent
7ce34fe1a5
commit
3d39e8c38c
1 file changed
+2
-2
@@ -31,7 +31,7 @@ function killcmd(procid, signal) {
|
||||
signal = 0;
|
||||
}
|
||||
// by default, we simply re-nice a process to check it is running
|
||||
return system(`kill -${signal} ${procid}`);
|
||||
return system(['kill', `-${signal}`, procid]);
|
||||
}
|
||||
|
||||
function trimnonewline(input) {
|
||||
@@ -134,7 +134,7 @@ const methods = {
|
||||
if (length(dnsServer) > 0) push(command, '-d', dnsServer);
|
||||
push(command, '-- get_registered_ip');
|
||||
|
||||
const result = system(`${join(' ', command)}`);
|
||||
const result = system(command);
|
||||
}
|
||||
|
||||
lastUpdate = int(readfile(`${rundir}/${section}.update`) || 0);
|
||||
|
||||
Reference in new issue
Block a user