Maintainer: @systemcrash
CC: @feckert
Version: Main
Compile tested: X86-64
Run tested: X86-64
Description:
The push_opt tab incorrectly registered a server-side auth_user_pass
Value option.
So move it to the client-side FileUpload option on the general tab.
auth_user_pass is a client-only option; the corresponding server-side
directive is auth-user-pass-verify, which is already correctly
defined under the scripts tab as auth_user_pass_verify.
Also update the general-tab auth_user_pass label to a clearer description
of the expected file format (username and password on separate lines).
Signed-off-by: Erik Conijn <egc112@msn.com>
According to the documentation, values from '1' to '4294967295' are allowed
values for the 'ifid' option. The value ‘0’ is excluded, as '0' is treated
as the default ID or an unassigned ID.
While we’re at it, mark the option as non-optional.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Properly escape the slash '/' chars that are included in the regex
strings in javascript files. Slash is used as a regex delimiter in
javascript, so an un-escaped slash may cause parsing errors in some
tools like xgettext used with .po translation manipulation.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Fix a typo in the cryptography tab where 'TLS cert profile' was
accidentally written as 'TLS cet profile'.
Signed-off-by: David Han <h96643864@gmail.com>
This hasn't knowingly caused problems before now, an indicator
that it goes lesser or unused hitherto.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Add a 'realm' field in the advanced tab so users can easily pass this
parameter to the underlying netifd handler.
Signed-off-by: Xing-Kai Wang <my@xkwang.org>
A batman-adv VLAN interface has protocol 'batadv_vlan' and allows
configuration of option 'ap_isolation' for a batman-adv VLAN device.
This adds support for configuration of such an interface to LuCI.
Signed-off-by: Bastiaan Stougie <wififreedom2026@protonmail.com>
The ACL permissions were originally authored to support just a single
set of modem interfaces, at the numbers 0-9. Eventually this was
adjusted to support from 0 to 999 avoiding command injection.
However, as new commands were added, this was reverted again
unfortunately. Language like "regex" has been used in the commit history
for this ACL, and likely the core of the issue is confusion on how these
are parsed. These are all parsed [1] with fnmatch(...), and not regex(..).
A future useful change could be for rpcd to set the FNM_EXTMATCH option
for fnmatch(...) to simplify this particular match statement, but that's
not considered here since that's a much broader change that needs a
longer discussion.
[1] https://github.com/openwrt/rpcd/blob/a4a5a298588960638a2e1713eb8fb858e1dbedeb/session.c#L143-L147
Fixes: 54aa70112c ("luci-proto-modemmanager: add status page")
Signed-off-by: Tim Nordell <tnordell@airgain.com>
make push(_reset) independent of server
The manual notes that push is a legal option in a client
context, i.e. the client can set these also.
Add also push_remove.
fix also the datatype for 'remote' to allow various combos.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
OpenVPN does have many options. To make it manageable, these options
are created by using a generic template. The necessary information for
the template is defined for each OpenVpn option in a single line.
This is very confusing and has the following disadvantages.
* Difficult to read, as the lines are very long with line breaks.
* A change in the option causes the entire line to be marked as changed.
This complicates the review process, as it is not immediately apparent
what has been changed.
The current format offers no advantage during development, as the code
will be minimised later anyway.
Therefore, this commit reformats the OpenVPN template option to make
the individual elements of the template easier to recognise.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
prevent global variable bleed and reduce size somewhat
-cbi
-network
-protocol/static
-rpc
-tools/widgets
-tools/views
-uci
protocols
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Previously, the render code attempted to add the class "hidden" to the button
row, the button row which can have a persistent visibility style applied via CSS
so the "hidden" class attribute was overridden. Set the style.display of the row
instead which now hides the button row.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
This adds the possibility to set our own L2TP hostname in the advanced
tab. It's needed if the peer only allows certain hostnames to connect.
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
IPv6 prefix length is normally valid in the range 0–64.
Additionally, /128 is a special case that needs to be supported.
Signed-off-by: Arayuki Mago <ms@missing233.com>
follow-up to: aa955d6465
Minor refactor of ucode, and some GUI fixes to ensure certificates are
written properly.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Clear, crisp, resolution independent vector graphics replace the trusty
microscopic PNG. Some minor CSS changes were needed to constrain images
in some locations to make sure they don't consume too much space.
Iconography taken from Mate desktop theme with minor adjustments:
https://github.com/mate-desktop/mate-icon-theme/
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Added the legacy peer name detection algorithm. If the new algorithm
fails to find a peer's name (e.g. when the IP address has been changed)
then the legacy value will be used.
Signed-off-by: Tom Haley <this_username_has_been_taken2@proton.me>
Erik Conijn
Florian Eckert
Jo-Philipp Wich
Hannu Nyman
Andy Chiang
David Han
Paul Donald
Xing-Kai Wang
Bastiaan Stougie
Tim Nordell
Martin Schiller
Alexander Ivanov
Arayuki Mago
Jan Pazdziora
this-username-has-been-taken