openwrt-mirror/openwrt
1
0 Fork 0
mirror of https://github.com/openwrt/openwrt.git synced 2026-10-12 06:57:57 +04:00
Code Issues Packages Projects Releases Wiki Activity

realtek: pcs: rtl83xx: name the SerDes soft reset field

Browse Source 
Document the common SerDes soft-reset register and field. Replace magic
register values in the RTL838x and RTL839x reset sequences with named,
SDK-style masked field updates. Merge the two sequences by dropping the
RTL839x-specific delay - which is unneeded according to the SDK - and
provide a combined helper.

Link: https://github.com/openwrt/openwrt/pull/25314
Signed-off-by: Jonas Jelonek <jonas@jonasjelonek.de>
This commit is contained in:
Jonas Jelonek committed 2026-09-23 19:30:21 +02:00
1 parent c1b568dbd7
commit b532485b4e
1 file changed
+14 -14
Download Patch File Download Diff File Expand all files Collapse all files
target/linux/realtek/files-6.18/drivers/net/pcs/pcs-rtl-otto.c
+14 -14
View File
@@ -169,6 +169,9 @@ enum rtpcs_page {
#define RTL838X_SDS_EN_RX BIT(1)
#define RTL838X_SDS_EN_TX BIT(0)
#define SDS_REG03 0x03
#define RTL83XX_SOFT_RST BIT(6)
#define SDS_REG04 0x04
#define RTL931X_CFG_EN_LINK_FIB1G BIT(2)
@@ -943,6 +946,14 @@ static int rtpcs_sds_set_mac_mode(struct rtpcs_serdes *sds, enum rtpcs_sds_mode
/* Variant-specific functions */
/* RTL83XX */
static void rtpcs_83xx_sds_soft_reset(struct rtpcs_serdes *sds)
{
rtpcs_sds_write_mask(sds, PAGE_SDS, SDS_REG03, RTL83XX_SOFT_RST, RTL83XX_SOFT_RST);
rtpcs_sds_write_mask(sds, PAGE_SDS, SDS_REG03, RTL83XX_SOFT_RST, 0);
}
/* RTL838X */
/* RTL838X SDS_MODE_SEL field values */
@@ -994,12 +1005,6 @@ static void rtpcs_838x_sds_patch_fiber(struct rtpcs_serdes *sds)
rtpcs_sds_write(sds, PAGE_FIB, 27, 0x4bf);
}
static void rtpcs_838x_sds_reset(struct rtpcs_serdes *sds)
{
rtpcs_sds_write_bits(sds, PAGE_SDS, 3, 6, 6, 0x1); /* REG3 SOFT_RST */
rtpcs_sds_write_bits(sds, PAGE_SDS, 3, 6, 6, 0x0); /* REG3 SOFT_RST */
}
static void rtpcs_838x_sds_fill_caps(struct rtpcs_serdes *sds)
{
__set_bit(RTPCS_SDS_MODE_OFF, sds->supported_modes);
@@ -1052,7 +1057,7 @@ static int rtpcs_838x_sds_activate(struct rtpcs_serdes *sds)
{
int ret;
rtpcs_838x_sds_reset(sds);
rtpcs_83xx_sds_soft_reset(sds);
ret = rtpcs_sds_write_mask(sds, PAGE_FIB, MII_BMCR, BMCR_PDOWN, 0);
if (ret)
@@ -1244,13 +1249,8 @@ static void rtpcs_839x_sds_reset(struct rtpcs_serdes *sds)
rtpcs_sds_write_bits(sds, PAGE_ANA_1G2, 0x14, 9, 9, 0x0);
}
rtpcs_sds_write(even_sds, PAGE_SDS, 0x3, 0x7146);
msleep(100);
rtpcs_sds_write(even_sds, PAGE_SDS, 0x3, 0x7106);
rtpcs_sds_write(odd_sds, PAGE_SDS, 0x3, 0x7146);
msleep(100);
rtpcs_sds_write(odd_sds, PAGE_SDS, 0x3, 0x7106);
rtpcs_83xx_sds_soft_reset(even_sds);
rtpcs_83xx_sds_soft_reset(odd_sds);
}
static void rtpcs_839x_sds_fill_caps(struct rtpcs_serdes *sds)