Markus Stockhausen
fad3ebd4f1
Initialize struct rtl838x_vlan_info with a designated initializer instead
of conditionally initializing the RTL931x-only fields based on
family_id.
The RTL931x VLAN table contains the additional if_id,
multicast_grp_mask and l2_tunnel_list_id fields. Of these,
if_id and multicast_grp_mask require the value zero during the
initial VLAN table setup, while l2_tunnel_list_id uses -1 to denote
that no L2 tunnel list is configured.
A designated initializer already zero-initializes every member which
is not explicitly specified. It is therefore sufficient to initialize
only l2_tunnel_list_id to -1:
struct rtl838x_vlan_info info = {
.l2_tunnel_list_id = -1,
};
This preserves the previous RTL931x values exactly:
if_id = 0
multicast_grp_mask = 0
l2_tunnel_list_id = -1
It also preserves the values previously assigned explicitly for all
families:
fid = 0
hash_uc_fid = false
hash_mc_fid = false
profile_id = 0
member_ports = 0
The RTL838x, RTL839x and RTL930x VLAN table writers do not consume the
RTL931x-specific members, so initializing those members unconditionally
has no effect on those SoCs. Their relevant members retain exactly the
same zero values as before.
For RTL931x, rtl931x_vlan_set_tagged() does consume the additional
members, but receives exactly the same values that were previously set
inside the RTL9310_FAMILY_ID conditional.
As a side effect, the whole structure is now initialized before first
use, including members such as untagged_ports which are not relevant
to this particular write path.
This removes one unnecessary family_id dependency from the common
DSA code without changing the generated VLAN table contents.
Assisted-by: ChatGPT (OpenAI GPT-5.6 Sol)
Link: https://github.com/openwrt/openwrt/pull/24918
Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
OpenWrt Project is a Linux operating system targeting embedded devices. Instead of trying to create a single, static firmware, OpenWrt provides a fully writable filesystem with package management. This frees you from the application selection and configuration provided by the vendor and allows you to customize the device through the use of packages to suit any application. For developers, OpenWrt is the framework to build an application without having to build a complete firmware around it; for users this means the ability for full customization, to use the device in ways never envisioned.
Sunshine!
Download
Built firmware images are available for many architectures and come with a package selection to be used as WiFi home router. To quickly find a factory image usable to migrate from a vendor stock firmware to OpenWrt, try the Firmware Selector.
If your device is supported, please follow the Info link to see install instructions or consult the support resources listed below.
An advanced user may require additional or specific package. (Toolchain, SDK, ...) For everything else than simple firmware download, try the wiki download page:
Development
To build your own firmware you need a GNU/Linux, BSD or macOS system (case sensitive filesystem required). Cygwin is unsupported because of the lack of a case sensitive file system.
Requirements
You need the following tools to compile OpenWrt, the package names vary between distributions. A complete list with distribution specific packages is found in the Build System Setup documentation.
binutils bzip2 diff find flex gawk gcc-6+ getopt grep install libc-dev libz-dev
make4.1+ perl python3.8+ rsync subversion unzip which
Quickstart
-
Run
./scripts/feeds update -ato obtain all the latest package definitions defined in feeds.conf / feeds.conf.default -
Run
./scripts/feeds install -ato install symlinks for all obtained packages into package/feeds/ -
Run
make menuconfigto select your preferred configuration for the toolchain, target system & firmware packages. -
Run
maketo build your firmware. This will download all sources, build the cross-compile toolchain and then cross-compile the GNU/Linux kernel & all chosen applications for your target system.
Related Repositories
The main repository uses multiple sub-repositories to manage packages of
different categories. All packages are installed via the OpenWrt package
manager called opkg. If you're looking to develop the web interface or port
packages to OpenWrt, please find the fitting repository below.
-
LuCI Web Interface: Modern and modular interface to control the device via a web browser.
-
OpenWrt Packages: Community repository of ported packages.
-
OpenWrt Routing: Packages specifically focused on (mesh) routing.
-
OpenWrt Video: Packages specifically focused on display servers and clients (Xorg and Wayland).
Support Information
For a list of supported devices see the OpenWrt Hardware Database
Documentation
Support Community
- Forum: For usage, projects, discussions and hardware advise.
- Support Chat: Channel
#openwrton oftc.net.
Developer Community
- Bug Reports: Report bugs in OpenWrt
- Dev Mailing List: Send patches
- Dev Chat: Channel
#openwrt-develon oftc.net.
License
OpenWrt is licensed under GPL-2.0